Skip to content

ci: use OIDC role secret for OIDC role in workflows#1062

Merged
pascal-pfeiffer merged 7 commits into
mainfrom
devops/dhanika/oidc-role-secret-update
Jun 3, 2026
Merged

ci: use OIDC role secret for OIDC role in workflows#1062
pascal-pfeiffer merged 7 commits into
mainfrom
devops/dhanika/oidc-role-secret-update

Conversation

@dhanikaa

@dhanikaa dhanikaa commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Replaces the hardcoded AWS OIDC role ARN in the test workflows with the GH_OIDC_ROLE_LLM_STUDIO_ENTERPRISE repository secret.

Previously the role was hardcoded in four places. Moving it to a secret avoids leaking the account ID/role in source and lets the role be rotated without code changes.

Changes

  • .github/workflows/test.ymlrole-to-assume in the start-runner and stop-runner jobs now reference ${{ secrets.GH_OIDC_ROLE_LLM_STUDIO_ENTERPRISE }}
  • .github/workflows/test_ui.yml — same change in both jobs

@dhanikaa dhanikaa self-assigned this Jun 3, 2026
@dhanikaa dhanikaa requested a review from pascal-pfeiffer as a code owner June 3, 2026 11:11

@pascal-pfeiffer pascal-pfeiffer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but please fix the creds

@pascal-pfeiffer pascal-pfeiffer merged commit 4d6bf70 into main Jun 3, 2026
5 of 6 checks passed
@pascal-pfeiffer pascal-pfeiffer deleted the devops/dhanika/oidc-role-secret-update branch June 3, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants